Skip to content

Remove all use of Drone, bump klipper-helm chart #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 25, 2025
Merged

Remove all use of Drone, bump klipper-helm chart #272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
90c2a7f
Remove all use of Drone
dereknola Mar 25, 2025
f21fa03
Bumper klipper-helm chart to v0.9.5-build20250306
dereknola Mar 25, 2025
a084787
Fix e2e script to be okay with failure
dereknola Mar 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 0 additions & 37 deletions .drone.yml
View file
Open in desktop

This file was deleted.

8 changes: 7 additions & 1 deletion .github/workflows/pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,10 @@ jobs:
run: make build

- name: Validate
run: make validate
run: make validate

- name: Package
run: make package

- name: E2E Test
run: ./scripts/e2e
3 changes: 3 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ jobs:
- name: Build and package
run: make

- name: Run E2E Tests
run: ./scripts/e2e

- name: Upload binary
uses: actions/upload-artifact@v4
with:
Expand Down
2 changes: 1 addition & 1 deletion pkg/controllers/chart/chart.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ const (
var (
commaRE = regexp.MustCompile(`\\*,`)
deletePolicy = metav1.DeletePropagationForeground
DefaultJobImage = "rancher/klipper-helm:v0.9.4-build20250113"
DefaultJobImage = "rancher/klipper-helm:v0.9.5-build20250306"
DefaultFailurePolicy = FailurePolicyReinstall
defaultBackOffLimit = ptr.To(int32(1000))

Expand Down
2 changes: 1 addition & 1 deletion scripts/e2e
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ fi
setup_k8s(){
# Drone launches each step in an isolated network. Check and see if there is another bridge network
# that is not the default bridge network. If so, use that network for the k3s node.
BRIDGE_NETWORKS=$(docker network ls --filter driver=bridge --format '{{.Name}}' | grep -v bridge)
BRIDGE_NETWORKS=$(docker network ls --filter driver=bridge --format '{{.Name}}' | grep -v bridge || true)
if [ -n "$BRIDGE_NETWORKS" ]; then
K3S_NODE_NETWORK=$(echo "$BRIDGE_NETWORKS" | head -n 1)
echo "Using network $K3S_NODE_NETWORK"
Expand Down