xds: SNI SAN changes #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e for SNI in ProtocolNegotiators.java
…channel authority itself.
…ootcerts-ignore-trusted-root-updates
…m-root-changes-needed # Conflicts: # xds/src/main/java/io/grpc/xds/internal/security/SslContextProviderSupplier.java # xds/src/test/java/io/grpc/xds/CdsLoadBalancer2Test.java # xds/src/test/java/io/grpc/xds/internal/security/SslContextProviderSupplierTest.java # xds/src/test/java/io/grpc/xds/internal/security/certprovider/CertProviderClientSslContextProviderTest.java
…lier and handle it in
…m-root-changes-needed # Conflicts: # xds/src/main/java/io/grpc/xds/internal/security/certprovider/CertProviderClientSslContextProvider.java # xds/src/test/java/io/grpc/xds/XdsSecurityClientServerTest.java
…m-root-changes-needed # Conflicts: # xds/src/test/java/io/grpc/xds/XdsSecurityClientServerTest.java
…ontext when SystemRootCerts is also there.
…usted-root-updates # Conflicts: # xds/src/main/java/io/grpc/xds/internal/security/certprovider/CertProviderClientSslContextProvider.java
…m-root-changes-needed # Conflicts: # xds/src/main/java/io/grpc/xds/ClusterResolverLoadBalancer.java # xds/src/main/java/io/grpc/xds/internal/security/certprovider/CertProviderClientSslContextProvider.java # xds/src/test/java/io/grpc/xds/ClusterResolverLoadBalancerTest.java # xds/src/test/java/io/grpc/xds/internal/security/certprovider/CertProviderClientSslContextProviderTest.java
kannanjgithub
changed the base branch from
systemrootcerts-ignore-trusted-root-updates
to
master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basing this PR on the branch used for the pending PR grpc#12340 for system root certs from my own repo to see incremental diffs.
Still some changes are pending - providing a flag for falling back to old behavior when no SNI for xds is found.