Skip to content

Conversation

@keithamus
Copy link
Contributor

Never swallow errors!

@doodlemoonch
Copy link

+1

@maksimr
Copy link
Contributor

maksimr commented Aug 21, 2014

@keithamus Thanks!

Can you fix 'jshint' error?

if (err) {
 throw err;
}

@keithamus
Copy link
Contributor Author

Done hopefully - I'm only using the github editor, not my local editor so fingers crossed 😉

@maksimr
Copy link
Contributor

maksimr commented Aug 22, 2014

Awesome!!
It remains only to change the commit message follow convention.
In your case something like:

fix(preprocessor): Throw error if can't open file (example)

Thank you for your patience :)

@keithamus
Copy link
Contributor Author

@maksimr Done and done.

@maksimr
Copy link
Contributor

maksimr commented Aug 22, 2014

LGTM

@keithamus
Copy link
Contributor Author

I can has merge?

@aymericbeaumet
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants