Skip to content

Make some cleanup in dependencies distributor #3827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2023
Merged

Make some cleanup in dependencies distributor #3827

merged 1 commit into from
Aug 1, 2023

Conversation

@XiShanYongYe-Chang
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang commented Jul 21, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Make some cleanup in the dependencies distributor:

  • Change some unnecessary exposed member variables to internal variables.
  • Delete some redundant code.
  • Modify inappropriate method or variable names.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 21, 2023
@XiShanYongYe-Chang
Copy link
Member Author

XiShanYongYe-Chang commented Jul 21, 2023

/cc @chaunceyjiang @mrlihanbo

@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 21, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2023 •
edited
Loading

Codecov Report

Merging #3827 (4620411) into master (4488898) will decrease coverage by 0.01%.
The diff coverage is 4.87%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #3827      +/-   ##
==========================================
- Coverage   54.95%   54.94%   -0.01%     
==========================================
  Files         227      227              
  Lines       21676    21676              
==========================================
- Hits        11911    11909       -2     
- Misses       9126     9128       +2     
  Partials      639      639
Flag Coverage Δ
unittests 54.94% <4.87%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ependenciesdistributor/dependencies_distributor.go 3.02% <4.87%> (ø)

... and 1 file with indirect coverage changes

@XiShanYongYe-Chang XiShanYongYe-Chang marked this pull request as draft July 21, 2023 08:50
@karmada-bot karmada-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 21, 2023
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the cleanup-dependencies-distributor branch from a1c5a2b to eec158f Compare July 21, 2023 09:00
@XiShanYongYe-Chang XiShanYongYe-Chang marked this pull request as ready for review July 21, 2023 09:37
@karmada-bot karmada-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 21, 2023
chaunceyjiang
chaunceyjiang reviewed Jul 24, 2023
View reviewed changes
Copy link
Member

@chaunceyjiang chaunceyjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign

jwcesign
jwcesign reviewed Jul 24, 2023
View reviewed changes
Copy link
Member

@jwcesign jwcesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!
/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2023
chaunceyjiang
chaunceyjiang reviewed Jul 24, 2023
View reviewed changes
Copy link
Member

@chaunceyjiang chaunceyjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~

LGTM

@RainbowMango
Copy link
Member

RainbowMango commented Jul 24, 2023

Please hold on for a while, #3730 might conflict with this.
/assign

@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the cleanup-dependencies-distributor branch from eec158f to 4620411 Compare July 31, 2023 08:47
@karmada-bot karmada-bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2023
RainbowMango
RainbowMango approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

karmada-bot commented Aug 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2023
@RainbowMango
Copy link
Member

RainbowMango commented Aug 1, 2023

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2023
@karmada-bot karmada-bot merged commit d916d87 into karmada-io:master Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RainbowMango RainbowMango RainbowMango approved these changes

@Garrybest Garrybest Awaiting requested review from Garrybest

@lonelyCZ lonelyCZ Awaiting requested review from lonelyCZ

@mrlihanbo mrlihanbo Awaiting requested review from mrlihanbo

+2 more reviewers

@chaunceyjiang chaunceyjiang chaunceyjiang left review comments

@jwcesign jwcesign jwcesign left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@RainbowMango RainbowMango

@chaunceyjiang chaunceyjiang

@jwcesign jwcesign

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@XiShanYongYe-Chang @codecov-commenter @RainbowMango @karmada-bot @chaunceyjiang @jwcesign