-
Notifications
You must be signed in to change notification settings - Fork 1k
migrate wait.PollUntil to wait.PollUntilContextCancel #4947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: zhzhuang-zju <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4947 +/- ##
==========================================
+ Coverage 53.21% 53.25% +0.03%
==========================================
Files 252 252
Lines 20514 20514
==========================================
+ Hits 10917 10924 +7
+ Misses 8878 8866 -12
- Partials 719 724 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
XiShanYongYe-Chang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
/lgtm
|
/assign |
RainbowMango
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Thanks.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The
wait.PollUtilmethods was deprecated in Kubernetes v1.27 (kubernetes/kubernetes#107826), so we need migratewait.PollUtiltowait.PollUtilContextCancelWhich issue(s) this PR fixes:
Parts of #3835
Special notes for your reviewer:
Does this PR introduce a user-facing change?: