Skip to content

JsonNumber implementation and tests #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kasiabulat merged 18 commits into from
Jul 30, 2019
Merged

JsonNumber implementation and tests #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
c41f55c
IEquatables added
kasiabulat Jul 24, 2019
ef2e3c6
JsonNUmber unit tests added, minor fixes
kasiabulat Jul 25, 2019
8c86888
constructors for JsonNumber added
kasiabulat Jul 29, 2019
847a3be
tests made public
kasiabulat Jul 29, 2019
26701b6
tests fixes
kasiabulat Jul 29, 2019
108a9ca
constructors changed to use setters
kasiabulat Jul 29, 2019
83f75eb
implicit operators changed to return new JsonNumber
kasiabulat Jul 29, 2019
b5eaa8f
byte[] changed to string, try get methods implemented
kasiabulat Jul 29, 2019
83c0adf
equals-related methods added
kasiabulat Jul 29, 2019
e020858
more tests added
kasiabulat Jul 29, 2019
c0bc7bb
pragmas deleted, methods changed into oneliners
kasiabulat Jul 30, 2019
0b26f7a
review comments included, more tests added
kasiabulat Jul 30, 2019
543500e
(Try)Get tests on different types added
kasiabulat Jul 30, 2019
ed5ad0d
ToString and changing types tests added
kasiabulat Jul 30, 2019
000dfbe
implicit operators test added
kasiabulat Jul 30, 2019
ea347ad
code refactored
kasiabulat Jul 30, 2019
55ae165
decimal support added to JsonNumber
kasiabulat Jul 30, 2019
f958996
decimal support added to JsonArray and JsonObject
kasiabulat Jul 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 24 additions & 5 deletions src/System.Text.Json/ref/System.Text.Json.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ public partial class JsonArray : System.Text.Json.JsonNode, System.Collections.G
public JsonArray() { }
public JsonArray(System.Collections.Generic.IEnumerable<bool> values) { }
public JsonArray(System.Collections.Generic.IEnumerable<byte> values) { }
public JsonArray(System.Collections.Generic.IEnumerable<decimal> values) { }
public JsonArray(System.Collections.Generic.IEnumerable<double> values) { }
public JsonArray(System.Collections.Generic.IEnumerable<short> values) { }
public JsonArray(System.Collections.Generic.IEnumerable<int> values) { }
Expand All @@ -32,6 +33,7 @@ public JsonArray(System.Collections.Generic.IEnumerable<ulong> values) { }
public System.Text.Json.JsonNode this[int idx] { get { throw null; } set { } }
public void Add(bool value) { }
public void Add(byte value) { }
public void Add(decimal value) { }
public void Add(double value) { }
public void Add(short value) { }
public void Add(int value) { }
Expand All @@ -50,6 +52,7 @@ public void Add(ulong value) { }
public void Clear() { }
public bool Contains(bool value) { throw null; }
public bool Contains(byte value) { throw null; }
public bool Contains(decimal value) { throw null; }
public bool Contains(double value) { throw null; }
public bool Contains(short value) { throw null; }
public bool Contains(int value) { throw null; }
Expand All @@ -69,6 +72,7 @@ public void Clear() { }
public int IndexOf(System.Text.Json.JsonNode item) { throw null; }
public void Insert(int index, bool item) { }
public void Insert(int index, byte item) { }
public void Insert(int index, decimal item) { }
public void Insert(int index, double item) { }
public void Insert(int index, short item) { }
public void Insert(int index, int item) { }
Expand All @@ -90,14 +94,17 @@ public void RemoveAt(int index) { }
void System.Collections.Generic.ICollection<System.Text.Json.JsonNode>.CopyTo(System.Text.Json.JsonNode[] array, int arrayIndex) { }
System.Collections.IEnumerator System.Collections.IEnumerable.GetEnumerator() { throw null; }
}
public partial class JsonBoolean : System.Text.Json.JsonNode
public partial class JsonBoolean : System.Text.Json.JsonNode, System.IEquatable<System.Text.Json.JsonBoolean>
{
public JsonBoolean() { }
public JsonBoolean(bool value) { }
public bool Value { get { throw null; } set { } }
public override bool Equals(object obj) { throw null; }
public bool Equals(System.Text.Json.JsonBoolean other) { throw null; }
public override int GetHashCode() { throw null; }
public static bool operator ==(System.Text.Json.JsonBoolean left, System.Text.Json.JsonBoolean right) { throw null; }
public static implicit operator System.Text.Json.JsonBoolean (bool value) { throw null; }
public static bool operator !=(System.Text.Json.JsonBoolean left, System.Text.Json.JsonBoolean right) { throw null; }
}
public enum JsonCommentHandling : byte
{
Expand Down Expand Up @@ -264,10 +271,11 @@ internal JsonNode() { }
public static System.Text.Json.JsonNode Parse(string json) { throw null; }
public static bool TryGetNode(System.Text.Json.JsonElement jsonElement, out System.Text.Json.JsonNode jsonNode) { throw null; }
}
public partial class JsonNumber : System.Text.Json.JsonNode
public partial class JsonNumber : System.Text.Json.JsonNode, System.IEquatable<System.Text.Json.JsonNumber>
{
public JsonNumber() { }
public JsonNumber(byte value) { }
public JsonNumber(decimal value) { }
public JsonNumber(double value) { }
public JsonNumber(short value) { }
public JsonNumber(int value) { }
Expand All @@ -283,7 +291,9 @@ public JsonNumber(uint value) { }
[System.CLSCompliantAttribute(false)]
public JsonNumber(ulong value) { }
public override bool Equals(object obj) { throw null; }
public bool Equals(System.Text.Json.JsonNumber other) { throw null; }
public byte GetByte() { throw null; }
public decimal GetDecimal() { throw null; }
public double GetDouble() { throw null; }
public override int GetHashCode() { throw null; }
public short GetInt16() { throw null; }
Expand All @@ -292,14 +302,15 @@ public JsonNumber(ulong value) { }
[System.CLSCompliantAttribute(false)]
public sbyte GetSByte() { throw null; }
public float GetSingle() { throw null; }
public string GetString() { throw null; }
[System.CLSCompliantAttribute(false)]
public ushort GetUInt16() { throw null; }
[System.CLSCompliantAttribute(false)]
public uint GetUInt32() { throw null; }
[System.CLSCompliantAttribute(false)]
public ulong GetUInt64() { throw null; }
public static bool operator ==(System.Text.Json.JsonNumber left, System.Text.Json.JsonNumber right) { throw null; }
public static implicit operator System.Text.Json.JsonNumber (byte value) { throw null; }
public static implicit operator System.Text.Json.JsonNumber (decimal value) { throw null; }
public static implicit operator System.Text.Json.JsonNumber (double value) { throw null; }
public static implicit operator System.Text.Json.JsonNumber (short value) { throw null; }
public static implicit operator System.Text.Json.JsonNumber (int value) { throw null; }
Expand All @@ -313,22 +324,26 @@ public JsonNumber(ulong value) { }
public static implicit operator System.Text.Json.JsonNumber (uint value) { throw null; }
[System.CLSCompliantAttribute(false)]
public static implicit operator System.Text.Json.JsonNumber (ulong value) { throw null; }
public static bool operator !=(System.Text.Json.JsonNumber left, System.Text.Json.JsonNumber right) { throw null; }
public void SetByte(byte value) { }
public void SetDecimal(decimal value) { }
public void SetDouble(double value) { }
public void SetFormattedValue(string value) { }
public void SetInt16(short value) { }
public void SetInt32(int value) { }
public void SetInt64(long value) { }
[System.CLSCompliantAttribute(false)]
public void SetSByte(sbyte value) { }
public void SetSingle(float value) { }
public void SetString(string value) { }
[System.CLSCompliantAttribute(false)]
public void SetUInt16(ushort value) { }
[System.CLSCompliantAttribute(false)]
public void SetUInt32(uint value) { }
[System.CLSCompliantAttribute(false)]
public void SetUInt64(ulong value) { }
public override string ToString() { throw null; }
public bool TryGetByte(out byte value) { throw null; }
public bool TryGetDecimal(out decimal value) { throw null; }
public bool TryGetDouble(out double value) { throw null; }
public bool TryGetInt16(out short value) { throw null; }
public bool TryGetInt32(out int value) { throw null; }
Expand All @@ -354,6 +369,7 @@ public void Add(System.Collections.Generic.KeyValuePair<string, System.Text.Json
public void Add(string propertyName, bool propertyValue) { }
public void Add(string propertyName, byte propertyValue) { }
public void Add(string propertyName, System.Collections.Generic.IEnumerable<System.Text.Json.JsonNode> propertyValue) { }
public void Add(string propertyName, decimal propertyValue) { }
public void Add(string propertyName, double propertyValue) { }
public void Add(string propertyName, short propertyValue) { }
public void Add(string propertyName, int propertyValue) { }
Expand Down Expand Up @@ -445,14 +461,17 @@ public JsonSerializerOptions() { }
public bool WriteIndented { get { throw null; } set { } }
public System.Text.Json.Serialization.JsonConverter GetConverter(System.Type typeToConvert) { throw null; }
}
public partial class JsonString : System.Text.Json.JsonNode
public partial class JsonString : System.Text.Json.JsonNode, System.IEquatable<System.Text.Json.JsonString>
{
public JsonString() { }
public JsonString(string value) { }
public string Value { get { throw null; } set { } }
public override bool Equals(object obj) { throw null; }
public bool Equals(System.Text.Json.JsonString other) { throw null; }
public override int GetHashCode() { throw null; }
public static bool operator ==(System.Text.Json.JsonString left, System.Text.Json.JsonString right) { throw null; }
public static implicit operator System.Text.Json.JsonString (string value) { throw null; }
public static bool operator !=(System.Text.Json.JsonString left, System.Text.Json.JsonString right) { throw null; }
}
public enum JsonTokenType : byte
{
Expand Down
4 changes: 4 additions & 0 deletions src/System.Text.Json/src/System/Text/Json/Node/JsonArray.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ public JsonArray(IEnumerable<ushort> values) { }
public JsonArray(IEnumerable<uint> values) { }
[CLSCompliant(false)]
public JsonArray(IEnumerable<ulong> values) { }
public JsonArray(IEnumerable<decimal> values) { }

public JsonNode this[int idx] { get => throw null; set => throw null; }

Expand All @@ -50,6 +51,7 @@ public void Add(ushort value) { }
public void Add(uint value) { }
[CLSCompliant(false)]
public void Add(ulong value) { }
public void Add(decimal value) { }

public void Insert(int index, JsonNode item) { throw null; }
public void Insert(int index, string item) { throw null; }
Expand All @@ -68,6 +70,7 @@ public void Add(ulong value) { }
public void Insert(int index, uint item) { throw null; }
[CLSCompliant(false)]
public void Insert(int index, ulong item) { throw null; }
public void Insert(int index, decimal item) { throw null; }

public bool Contains(JsonNode value) { throw null; }
public bool Contains(string value) { throw null; }
Expand All @@ -86,6 +89,7 @@ public void Add(ulong value) { }
public bool Contains(uint value) { throw null; }
[CLSCompliant(false)]
public bool Contains(ulong value) { throw null; }
public bool Contains(decimal value) { throw null; }

public int Count => throw null;
public bool IsReadOnly => throw null;
Expand Down
8 changes: 6 additions & 2 deletions src/System.Text.Json/src/System/Text/Json/Node/JsonBoolean.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

namespace System.Text.Json
{
public partial class JsonBoolean : JsonNode
public partial class JsonBoolean : JsonNode, IEquatable<JsonBoolean>
{
public JsonBoolean() { }
public JsonBoolean(bool value) { }
Expand All @@ -18,7 +18,11 @@ public JsonBoolean(bool value) { }

public override bool Equals(object obj) { throw null; }
public override int GetHashCode() { throw null; }

public bool Equals(JsonBoolean other) { throw null; }

public static bool operator ==(JsonBoolean left, JsonBoolean right) => throw null;
public static bool operator !=(JsonBoolean left, JsonBoolean right) => throw null;
}
}

#pragma warning restore CS1591
Loading