Skip to content

Conversation

kbond
Copy link
Owner

@kbond kbond commented Jan 26, 2022

No description provided.

kbond pushed a commit that referenced this pull request Sep 13, 2023
I have a custom hydration extension that in `supports` method checks if the provided class has my custom marker attribute through Reflection, but SA complains:

> Parameter #1 $objectOrClass of class ReflectionClass constructor expects class-string<T of object>|T of object, string given.
kbond pushed a commit that referenced this pull request Sep 13, 2023
…ExtensionInterface (norkunas)

This PR was merged into the 2.x branch.

Discussion
----------

[LiveComponent] Add missing typehints to HydrationExtensionInterface

| Q             | A
| ------------- | ---
| Bug fix?      | no /not sure
| New feature?  | no /not sure
| Tickets       | N/A
| License       | MIT

I have a custom hydration extension that in `supports` method checks if the provided class has my custom marker attribute through Reflection, but SA complains:

> Parameter `#1` $objectOrClass of class ReflectionClass constructor expects class-string<T of object>|T of object, string given.

Commits
-------

7f8279c [LiveComponent] Add missing typehints to HydrationExtensionInterface
kbond added a commit that referenced this pull request Apr 24, 2024
…ceLoader if the parent $loader is null (vesselind)

This PR was merged into the 2.x branch.

Discussion
----------

symfony#1770 [Autocomplete] Ignore the ExtraLazyChoiceLoader if the parent $loader is null

| Q             | A
| ------------- | ---
| Bug fix?      | yes/no
| New feature?  | no
| Issues        | Fix symfony#1770
| License       | MIT

When a custom autoload field class is created and `choices` option is passed, an error occurs: `Symfony\UX\Autocomplete\Form\ChoiceList\Loader\ExtraLazyChoiceLoader::__construct(): Argument #1 ($decorated) must be of type Symfony\Component\Form\ChoiceList\Loader\ChoiceLoaderInterface, null given`.

This should fix the problem, described in symfony#1770.

Commits
-------

28af7fc symfony#1770 ignore the ExtraLazyChoiceLoader if the parent $loader is null
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant