Add MountedComponent object
#2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbond
commented
Jan 31, 2022
| return $this->mounted->getMetadata(); | ||
| } | ||
|
|
||
| public function getMountedComponent(): MountedComponent |
There was a problem hiding this comment.
I wonder if we should drop getMetadata/getComponent and just have this method?
Alternatively, MountedComponent is sort of an "internal" object so maybe we shouldn't include at all... We may want to keep it purely internal to allow us to make changes (add attributes via extension points) down the road.
The problem is, I need an instance of MountedComponent in the AddLiveAttributesSubscriber (to dehydrate the component) - this was the easiest way to provide.
kbond
pushed a commit
that referenced
this pull request
Nov 6, 2022
# This is the 1st commit message: WIP heavy refactoring to Component Initial "hook" system used to reset model field after re-render Adding a 2nd hook to handle window unloaded reinit polling after re-render Adding Component proxy # This is the commit message #2: fixing some tests # This is the commit message #3: Refactoring loading to a hook # This is the commit message #4: fixing tests # This is the commit message #5: rearranging # This is the commit message #6: Refactoring polling to a separate class
kbond
added a commit
that referenced
this pull request
Apr 20, 2024
This PR was merged into the 2.x branch. Discussion ---------- [LazyImage] Cache BlurHash, close #2 | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | Issues | Fix #2 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - For new features, provide some code snippets to help understand usage. - Features and deprecations must be submitted against branch main. - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> Hi everyone, this PR is a proposal for #2, the second oldest issue on this repository 🤯 In some weeks at work we want to setup BlurHash images for performance reasons, caching them the first step! I've also though about decorates the `BlurHashInterface` if option `cache` is set, this way we don't modify the current `BlurHash`. Let me know what is preferred :) Commits ------- 21e3c43 [LazyImage] Cache BlurHash, close #2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
MountedComponentobject as a base for adding native attributes.