Skip to content

Conversation

@jeherve
Copy link

@jeherve jeherve commented Jun 5, 2019

Changes proposed in this Pull Request:

  • Rely on esc_url_raw for remote call
  • Clarify update process for the map, and coding standard changes
    • A few additional comments help understand when has_good_map is needed.
    • Use Yoda conditions, we must
  • Simplify addition of query params to Google embed URL.
  • Enqueue CSS on widgets page as well: this avoids that the map breaks out of the widget area layout when displayed.
  • Display output from API request in widget area when error. This gives more information to users who entered an API key that is not correct for example, instead of just not displaying any map at all.

Testing instructions:

Proposed changelog entry for your changes:

  • None

jeherve added 6 commits June 5, 2019 11:39
- A few additional comments help understand when has_good_map is needed.
- Use Yoda conditions, we must
This avoids that the map breaks out of the widget area layout when displayed.
- This gives more information to users who entered an API key that is not correct for example, instead of just not displaying any map at all.
@kbrown9 kbrown9 merged this pull request into kbrown9:update/contact_info_widget_remove_geocoding Jun 10, 2019
@jeherve jeherve deleted the update/contact_info_widget_remove_geocoding branch June 10, 2019 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants