Skip to content

Conversation

sttts
Copy link
Member

@sttts sttts commented Jun 14, 2024

No description provided.

@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 14, 2024
@mjudeikis
Copy link

/retest

@mjudeikis
Copy link

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2024
@kcp-ci-bot
Copy link

LGTM label has been added.

Git tree hash: 171540cd669444762c06ad9c4815543715eb54e8

@mjudeikis
Copy link

/retest

xrstf and others added 2 commits July 1, 2024 14:06
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
@sttts sttts force-pushed the sttts-kcp-0.18 branch from f3ed7e5 to 6c54815 Compare July 1, 2024 12:07
@kcp-ci-bot kcp-ci-bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2024
@kcp-ci-bot kcp-ci-bot requested a review from mjudeikis July 1, 2024 12:07
@sttts
Copy link
Member Author

sttts commented Jul 1, 2024

/approve

@mjudeikis
Copy link

/lgtm

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2024
@kcp-ci-bot
Copy link

LGTM label has been added.

Git tree hash: 317c8bc57bc9b6747a79dc05cb4aab765495e483

@luxas
Copy link

luxas commented Jul 1, 2024

Woop woop, thanks @sttts \o/

@sttts sttts added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2024
@kcp-ci-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: mjudeikis, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot merged commit a3df1ba into kcp-dev:kcp-0.18 Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants