"Reopen database" shortcut

[a2kolbasov]

Now the keyboard shortcut uses the #reopen-database-button functionality from popup.js ⇒ no credential extraction is required.

Fixes #2766

Screenshots or videos

Testing strategy

Manually

Type of change

• ✅ Bug fix (non-breaking change that fixes an issue)
• ✅ New feature (change that adds functionality)

[a2kolbasov]

keepassxc-browser/keepassxc-browser/content/keepassxc-browser.js

Lines 649 to 664 in 8c3df94

	// The basic function for retrieving credentials from KeePassXC.
	// Credential Banner can force the retrieval for reloading new/modified credentials.
	kpxc.retrieveCredentials = async function(force = false) {
	if (!await isIframeAllowed()) {
	return;
	}
	kpxc.url = document.location.href;
	kpxc.submitUrl = kpxc.getFormActionUrl(kpxc.combinations[0]);
	if (kpxc.settings.autoRetrieveCredentials && kpxc.url && kpxc.submitUrl) {
	await kpxc.retrieveCredentialsCallback(
	await sendMessage('retrieve_credentials', [ kpxc.url, kpxc.submitUrl, force ]),
	);
	}
	};

This function is blocked by the autoRetrieveCredentials setting. If the user turned it off, then manually requested credentials, and then changed something in the database, he does not have the opportunity to request them again without updating the page.

This can be fixed by adding force || autoRetrieveCredentials. But force is also called when saving new credentials:

keepassxc-browser/keepassxc-browser/content/banner.js

Lines 370 to 384 in 8c3df94

	kpxcBanner.verifyResult = async function(code) {
	if (code === 'error') {
	kpxcUI.createNotification('error', tr('rememberErrorCannotSaveCredentials'));
	} else if (code === 'created') {
	kpxcUI.createNotification(
	'success',
	tr('rememberCredentialsSaved', kpxcBanner.credentials.username || tr('rememberEmptyUsername')),
	);
	await kpxc.retrieveCredentials(true); // Forced reload
	} else if (code === 'updated') {
	kpxcUI.createNotification(
	'success',
	tr('rememberCredentialsUpdated', kpxcBanner.credentials.username || tr('rememberEmptyUsername')),
	);
	await kpxc.retrieveCredentials(true); // Forced reload

Is it necessary to introduce a new function/parameter to separate the manual request from the user?

kpxc.retrieveCredentials = async function(force = false, manualRequest = false) {...}

[varjolintu]

This function is blocked by the autoRetrieveCredentials setting. If the user turned it off, then manually requested credentials, and then changed something in the database, he does not have the opportunity to request them again without updating the page.

The check should probably be:

if ((kpxc.settings.autoRetrieveCredentials || force) && kpxc.url && kpxc.submitUrl) {

But.. maybe this could be solved in another PR.