Skip to content

Fix getting submitted username for Credential Banner#2985

Open
varjolintu wants to merge 1 commit into
developfrom
fix/get_submitted_username
Open

Fix getting submitted username for Credential Banner#2985
varjolintu wants to merge 1 commit into
developfrom
fix/get_submitted_username

Conversation

@varjolintu
Copy link
Copy Markdown
Member

Sites with two phase login (a separate username and password field pages), when showing the Credential Banner, the username has no longer a valid input field inside the form. The value retrieved for the banner is empty, or incorrect value from another text input.

Instead, rely on the page_get_submitted request that has the previously entered username in the background script's memory. If the form username differs from the submitted one, use the previously submitted username. Pages where the login form that has both fields, the page_get_submitted returns an empty object, and the username value from the form is used normally.

Testing strategy

Use site https://www.blsk.de/de/home.html or Microsoft login page to test the fix. Without the fix, username for the first page is always "1". With Microsoft's login page, the username is empty.

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@varjolintu varjolintu added this to the 1.10.3 milestone May 29, 2026
@varjolintu varjolintu requested a review from droidmonkey May 29, 2026 19:23
@varjolintu varjolintu added the bug label May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

After login always new entry with username 1 pop up on sparkasse website

1 participant