Fix getting submitted username for Credential Banner#2985
Open
varjolintu wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sites with two phase login (a separate username and password field pages), when showing the Credential Banner, the username has no longer a valid input field inside the form. The value retrieved for the banner is empty, or incorrect value from another text input.
Instead, rely on the
page_get_submittedrequest that has the previously entered username in the background script's memory. If the form username differs from the submitted one, use the previously submitted username. Pages where the login form that has both fields, thepage_get_submittedreturns an empty object, and the username value from the form is used normally.Testing strategy
Use site https://www.blsk.de/de/home.html or Microsoft login page to test the fix. Without the fix, username for the first page is always "1". With Microsoft's login page, the username is empty.
Type of change