This repository was archived by the owner on Feb 7, 2025. It is now read-only.
Upgrades #4
Open
Upgrades #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZY-Ang
commented
Mar 25, 2020
ZY-Ang
commented
- Significantly better README.md
- Added an aurora serverless cluster as per your article
- Removed some params and added others
- Added security groups
- Refactor template.yaml with Fn::Sub so more readable.
So other people will be prompted for their parameter overrides
Use Sub functions to make it easier to read
- Add dbCluster - Add Security Groups - Remove VpcSecurityGroupIds parameter - Add VpcId and database parameters - Configure phpserver to work with database directly
Use connection from dbCluster
User friendly
- Add constraint for CloudFrontPriceClass - Remove NoEcho in DBUser to allow default value
Owner
|
Thanks for this, this is great! Looking at this, can you double check the subnet to see if it has Internet access? If that's the cause of #3 I'd like to add a note about which subnet you choose to assign. |
Removing caching of 504's due to aurora serverless cold starts on cloudfront
Author
|
I haven't gone so far as to include a new VPC configuration for this PR, as that's not really the point of this repo. Only new params are for the database and replacing the security group param with the VpcId to be deployed to as we streamline the security group for them. This still gets the user to choose their own VPC and subnets with internet access, unless they want only intra-network access.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.