Skip to content

T5 checkpoint conversion with HF #1277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Oct 24, 2023
Merged

T5 checkpoint conversion with HF #1277

merged 17 commits into from
Oct 24, 2023

Conversation

nkovela1
Copy link
Collaborator

This PR adds checkpoint conversion from HF T5 models to our KerasNLP models, generating the associated presets and verifying correctness.

@nkovela1 nkovela1 requested a review from mattdangerw October 19, 2023 22:54
@mattdangerw mattdangerw mentioned this pull request Oct 19, 2023
Closed
mattdangerw
mattdangerw requested changes Oct 19, 2023
View reviewed changes
Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Couple comments.

mattdangerw
mattdangerw approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Just one comment.

@mattdangerw
Copy link
Member

/gcbrun

@mattdangerw
Copy link
Member

/gcbrun

@mattdangerw mattdangerw merged commit c5a531a into keras-team:master Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattdangerw mattdangerw mattdangerw approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nkovela1 @mattdangerw