Another fix for saving on Keras 2 #1354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This we would also catch if we were running our large testing on 2.13 or 2.14. Tensorflow will turn all dictionary attributes on a layer into "trackable dicts" python does not know how to save these, so we need to cast our byte pair vocabulary to a dict before writing the json.
mattdangerw
added a commit
that referenced
this pull request
Dec 8, 2023
This we would also catch if we were running our large testing on 2.13 or 2.14. Tensorflow will turn all dictionary attributes on a layer into "trackable dicts" python does not know how to save these, so we need to cast our byte pair vocabulary to a dict before writing the json.
sampathweb
pushed a commit
that referenced
this pull request
Dec 12, 2023
This we would also catch if we were running our large testing on 2.13 or 2.14. Tensorflow will turn all dictionary attributes on a layer into "trackable dicts" python does not know how to save these, so we need to cast our byte pair vocabulary to a dict before writing the json.
mattdangerw
added a commit
to mattdangerw/keras-hub
that referenced
this pull request
Dec 26, 2023
This we would also catch if we were running our large testing on 2.13 or 2.14. Tensorflow will turn all dictionary attributes on a layer into "trackable dicts" python does not know how to save these, so we need to cast our byte pair vocabulary to a dict before writing the json.
mattdangerw
added a commit
that referenced
this pull request
Jan 4, 2024
This we would also catch if we were running our large testing on 2.13 or 2.14. Tensorflow will turn all dictionary attributes on a layer into "trackable dicts" python does not know how to save these, so we need to cast our byte pair vocabulary to a dict before writing the json.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This we would also catch if we were running our large testing on 2.13 or 2.14. Tensorflow will turn all dictionary attributes on a layer into "trackable dicts." Python does not know how to save these, so we need to cast our byte pair vocabulary to a dict before writing the json.