ElectraTokenizer #1357
Merged
ElectraTokenizer #1357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Please check the tests! Looks like some legitimate failures. |
Member
|
I'll be out next week, so tagged @tirthasheshpatel and @nkovela1 to take a look. |
|
|
||
|
|
||
| @keras_nlp_export("keras_nlp.models.ElectraTokenizer") | ||
| class ElectraTokenizer(WordPieceTokenizer): |
Contributor
There was a problem hiding this comment.
Since we are exporting this class, can you add an example on how to use this? Something like:
vocab = ["[UNK]", "[CLS]", "[SEP]", "[PAD]", "[MASK]"]
vocab += ["The", "quick", "brown", "fox", "jumped", "."]
# Instantiate the tokenizer.
tokenizer = keras_nlp.models.ElectraTokenizer(vocabulary=vocab)
# Unbatched input.
tokenizer("The quick brown fox jumped.")
# Batched input.
tokenizer(["The quick brown fox jumped.", "The fox slept."])
# Detokenization.
tokenizer.detokenize(tokenizer("The quick brown fox jumped."))
tirthasheshpatel
approved these changes
Dec 15, 2023
Contributor
tirthasheshpatel
left a comment
tirthasheshpatel
left a comment
There was a problem hiding this comment.
LGTM except one minor comment. Thanks for the PR @pranavvp16!
Contributor
|
Merged, thanks @pranavvp16! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added the electratokenizer . notebook demonstrating that tokens match