Skip to content

Conversation

mbrhd
Copy link
Contributor

@mbrhd mbrhd commented Dec 12, 2023

Fixes #1358

Small PR changing the way to output the pooling_output.

Copy link

google-cla bot commented Dec 12, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@mbrhd mbrhd force-pushed the fixes/keras-team/keras-nlp#1358 branch from a45d888 to ff2a09c Compare December 12, 2023 21:40
@mattdangerw mattdangerw self-requested a review December 19, 2023 23:00
Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one nit.

Also, sorry for the delay, was on vacation, just got back in.

@mattdangerw
Copy link
Member

Thank you!

@mattdangerw mattdangerw merged commit 1248682 into keras-team:master Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incoherence in the pooled_output definition in ElectraBackbone and BertBackbone

2 participants