Fix print_fn issue in task test
#1563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fchollet
reviewed
Apr 9, 2024
| model = SimpleTask(preprocessor) | ||
| summary = [] | ||
| model.summary(print_fn=lambda x, line_break: summary.append(x)) | ||
| model.summary(print_fn=lambda x, line_break=False: summary.append(x)) |
There was a problem hiding this comment.
You should be able to skip line_break entirely, no?
model.summary(print_fn=lambda x: summary.append(x))
There was a problem hiding this comment.
I also think we should remove line_break but when I do that, it goes to this branch and gives the following error:
TypeError: TestTask.test_summary_with_preprocessor.<locals>.<lambda>() got an unexpected keyword argument 'line_break'
I should figure out why this branch runs when I remove line_break.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.