Fix Keras import #1593
Merged
Fix Keras import #1593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| from keras_nlp.backend import config | ||
|
|
||
| if config.keras_3(): | ||
| from keras import * # noqa: F403, F401 |
There was a problem hiding this comment.
I'm curious to know that now that we don't have keras.py anymore and the Keras import is handled in the __init__.py, how from keras_nlp.backend import keras works.
There was a problem hiding this comment.
It will import keras3 directly from __init__.py or keras2.py as keras.
sampathweb
force-pushed
the
fix-keras-import
branch
from
8daf176 to
dedf36f
Compare
fchollet
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the change in
keras3to usesrcandapifolders, thefrom keras import *insidekeras_nlp/backend/keras.pydoesn't import thesrcnamespace.To fix this -
keras.pytokeras2.pykerasinbackend/__init__.pyThis change has no impact to the users since its only required for accessing private files in Tests.