Skip to content

Check kagglehub version before upload #1594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Check kagglehub version before upload #1594

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8818403
Check kagglehub version before upload.
SamanehSaadat Apr 23, 2024
4162f7c
Parse version.
SamanehSaadat Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions keras_nlp/utils/preset_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import re

from absl import logging
from packaging.version import parse

from keras_nlp.api_export import keras_nlp_export
from keras_nlp.backend import config as backend_config
Expand Down Expand Up @@ -437,6 +438,16 @@ def upload_preset(
_validate_tokenizer(preset, allow_incomplete)

if uri.startswith(KAGGLE_PREFIX):
if kagglehub is None:
raise ImportError(
"Uploading a model to Kaggle Hub requires the `kagglehub` package. "
"Please install with `pip install kagglehub`."
)
if parse(kagglehub.__version__) < parse("0.2.1"):
raise ImportError(
"Uploading a model to Kaggle Hub requires the `kagglehub` package version `0.2.1` or higher. "
"Please upgrade with `pip install --upgrade kagglehub`."
)
kaggle_handle = uri.removeprefix(KAGGLE_PREFIX)
kagglehub.model_upload(kaggle_handle, preset)
elif uri.startswith(HF_PREFIX):
Expand Down