Ignore PEP8 W503 #10976
Merged
Ignore PEP8 W503 #10976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytest.ini
Outdated
|
|
||
| pep8ignore=* E402 \ | ||
| * E731 \ | ||
| # W503 \ |
There was a problem hiding this comment.
Should't it be * W503 \ instead of # W503 \ ?
Currently this line is interpreted as a comment.
There was a problem hiding this comment.
Sorry my bad. Fixed.
joelthchao
force-pushed
the
ignore-pep8-w503
branch
from
84f122d to
fcc7b17
Compare
fchollet
previously approved these changes
Aug 25, 2018
|
Please resolve merge conflicts. |
joelthchao
force-pushed
the
ignore-pep8-w503
branch
from
fcc7b17 to
f3016a8
Compare
|
Merge conflicts resolved. Suffer from unrelated error in unit test. |
fchollet
approved these changes
Aug 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As suggest in pep-8, we should ignore
W503to allow breaking line before a binary operator and improve readability.Related Issues
#10975
PR Overview