Skip to content

Fix file leak in CSVLogger #13378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 4, 2019
Merged

Fix file leak in CSVLogger #13378

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56cdde8
Fix file leak in CSVLogger
GregoryMorse Sep 30, 2019
c96af21
Update callbacks.py
GregoryMorse Oct 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix file leak in CSVLogger
  • Loading branch information
@GregoryMorse
GregoryMorse authored Sep 30, 2019
commit 56cdde8eb93d51f38f221501ad0865a6d7ef6425
4 changes: 4 additions & 0 deletions keras/callbacks/callbacks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1154,6 +1154,10 @@ class CustomDialect(csv.excel):
def on_train_end(self, logs=None):
self.csv_file.close()
self.writer = None

def __del__(self):
if hasattr(self, 'csv_file') and not self.csv_file.closed:
self.csv_file.close()


class LambdaCallback(Callback):
Expand Down