Skip to content

Fixing batch_dim_name attribute #20674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 7, 2025
+32 −18
Merged

Fixing batch_dim_name attribute #20674

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6ecc55c
fixing wrong trainer assumption that batch dim is always the first on…
martin-gorner Dec 20, 2024
830eed2
need functools partial
martin-gorner Dec 20, 2024
2da7fdc
lint
martin-gorner Dec 20, 2024
fb6c5ae
fix test failure when distribution=None
martin-gorner Dec 20, 2024
63c1f15
lint2
martin-gorner Dec 20, 2024
a64e093
fix for test failure
martin-gorner Dec 20, 2024
64293de
added data sharding for 3D+ meshes
martin-gorner Dec 20, 2024
d635f47
lint3
martin-gorner Dec 20, 2024
5e7b344
Merge branch 'keras-team:master' into master
martin-gorner Jan 6, 2025
32f5806
added @property for batch_dim_name + refactoring
martin-gorner Jan 6, 2025
a7afa74
fix typo
martin-gorner Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix for test failure
  • Loading branch information
@martin-gorner
martin-gorner committed Dec 20, 2024
commit a64e0933c81e1cfd68a7c1f8d2fc6ddd850781d7
2 changes: 1 addition & 1 deletion keras/src/backend/jax/distribution_lib_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ def test_distribute_data_input(self):
mesh, jax.sharding.PartitionSpec("batch", None)
)

result = backend_dlib.distribute_data_input(per_process_batch, layout)
result = backend_dlib.distribute_data_input(per_process_batch, layout, "batch")

# Check the shape of the global batch array
self.assertEqual(
Expand Down