Skip to content

Auto-scale Y-axis for indicators when zooming #356 #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 18 commits into from
Closed

Auto-scale Y-axis for indicators when zooming #356 #357

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
0581c55
Auto-scale Y-axis for indicators when zooming #356
zlpatel May 23, 2021
7792588
Auto-scale Y-axis for indicators when zooming #356
zlpatel May 23, 2021
4ff1fe8
Auto-scale Y-axis for indicators when zooming #356
zlpatel May 23, 2021
c0dcbbe
Auto-scale Y-axis for indicators when zooming #356
zlpatel May 23, 2021
6b1c436
Auto-scale Y-axis for indicators when zooming #356
zlpatel May 23, 2021
bf03b63
Auto-scale Y-axis for indicators when zooming #356
zlpatel May 23, 2021
5ca9a59
Auto-scale Y-axis for Profit/Loss chart when zooming kernc#356
zlpatel Jun 13, 2021
ab17cbf
Auto-scale Y-axis for PL chart when zooming kernc#356
zlpatel Jun 13, 2021
44a0200
Add auto scaling of y-axis for PL chart kernc#356
zlpatel Jun 13, 2021
307e4ff
Add whitespace after , to fix lint issue kernc#356
zlpatel Jun 13, 2021
97712c7
Fixing build error by adding [:] kernc#356
zlpatel Jun 13, 2021
1494396
Remove y-axis scaling logic for PnL graph kernc#356
zlpatel Jun 13, 2021
95e03f8
Remove y-axis scaling logic for PnL graph kernc#356
zlpatel Jun 13, 2021
50fd012
Auto-scale Y-axis for indicators when zooming #356
zlpatel May 23, 2021
8386f9e
Merge branch 'kernc#356' of https://github.com/zlpatel/backtesting.py…
zlpatel Jun 15, 2021
420c259
Fix indicator index mapping kernc#356
zlpatel Jun 17, 2021
453dd7b
Fix lint issues kernc#356
zlpatel Jun 17, 2021
9baed4e
Fix flake8 formatting issue kernc#356
zlpatel Jun 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix lint issues #356
  • Loading branch information
@zlpatel
zlpatel committed Jun 17, 2021
commit 453dd7bf75dcb2b0a832c1745fcf1ba8de133124
4 changes: 2 additions & 2 deletions backtesting/_plotting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,9 +620,9 @@ def __eq__(self, other):
if plot_volume:
custom_js_args.update(volume_range=fig_volume.y_range)
indicator_ranges = {}
for idx,(indicator,indicator_idx) in enumerate(zip(indicator_figs, non_overlay_indicator_idxs)):
for idx, (indicator, indicator_idx) in enumerate(zip(indicator_figs, non_overlay_indicator_idxs)):
indicator_range_key = f'indicator_{indicator_idx}_range'
indicator_ranges.update({indicator_range_key:indicator.y_range})
indicator_ranges.update({indicator_range_key: indicator.y_range})
custom_js_args.update({'indicator_ranges': indicator_ranges})
fig_ohlc.x_range.js_on_change('end', CustomJS(args=custom_js_args,
code=_AUTOSCALE_JS_CALLBACK))
Expand Down