Add NuGet packaging and GitHub Packages upload to CI #266
Conversation
Add three new steps to the CI workflow: 1. Pack NuGet package: - Builds Release configuration of Scrutor.csproj - Outputs to ./artifacts directory - Creates deterministic .nupkg and .snupkg files 2. Upload NuGet package artifact: - Makes packages available as GitHub Actions artifacts - Useful for debugging and manual downloads - Preserved for workflow retention period 3. Push to GitHub Packages: - Only runs on push events (not pull requests) - Only runs on khellang/* repositories - Uses GITHUB_TOKEN for authentication - Skips duplicates to avoid errors on re-runs - Publishes to GitHub's NuGet feed This enables automatic package distribution on every push while maintaining deterministic, reproducible builds.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #266 +/- ##
===========================================
+ Coverage 64.71% 86.31% +21.60%
===========================================
Files 25 29 +4
Lines 1278 2053 +775
Branches 0 247 +247
===========================================
+ Hits 827 1772 +945
+ Misses 451 250 -201
- Partials 0 31 +31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
khellang
deleted the
claude/upgrade-to-dotnet-01HBTW8qPH6GH7H2tV8LnYVo
branch
There was a problem hiding this comment.
Pull request overview
This PR adds automated NuGet package creation and publishing to the CI workflow. It enables packages to be built on every workflow run, uploaded as artifacts for manual access, and automatically published to GitHub Packages when code is pushed to the main repository.
Key Changes:
- NuGet package creation in Release configuration with output to
./artifacts - Artifact upload to GitHub Actions for debugging and manual downloads
- Conditional publishing to GitHub Packages for push events on khellang/* repositories
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: nuget-packages | ||
| path: ./artifacts/*.nupkg |
There was a problem hiding this comment.
The artifact upload path pattern ./artifacts/*.nupkg only matches .nupkg files but not .snupkg (symbol package) files. According to the PR description, both .nupkg and .snupkg files are created. Consider using ./artifacts/*.*nupkg or ./artifacts/** to include both package types in the artifact upload.
| path: ./artifacts/*.nupkg | |
| path: ./artifacts/*.*nupkg |
Add three new steps to the CI workflow:
Pack NuGet package:
Upload NuGet package artifact:
Push to GitHub Packages:
This enables automatic package distribution on every push while maintaining deterministic, reproducible builds.