Fix bug in module user systemd unit handling#16
Merged
kiviktnm merged 2 commits intokiviktnm:mainfrom Jan 25, 2025
Merged
Conversation
Author
|
Also lmao how do I draft in github |
oatmealraisin
changed the title
Author
|
I've added a test for this fix, no longer in draft |
Owner
|
Looks good! I don't use a ton of user services so I never caught that. Thanks! I'll merge this. I'll look into updating testing later, but I'd prefer to stay with stdlib for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple fix for a bug I noticed in my own usage.
updateclobbers the existing set upon key collisions. I have most 'applications' set up as modules, so each one that ran a user unit as my user overwrote the previous set of user units.This is a draft while I write unit tests for this. I wanted to ask if I could add
pytestas a dev dependency. I think the suites you have would get more clarity from thefixturepattern that pytest provides. If you'd prefer to stick tostdlib, that's fine.