Parse video page if embedding the video on other sites has been disabled#144
Merged
Julian-Chu merged 3 commits intokkdai:masterfrom Feb 3, 2021
Merged
Conversation
Collaborator
|
great!! we will review it soon. |
Julian-Chu
requested changes
Feb 2, 2021
Collaborator
Julian-Chu
left a comment
Julian-Chu
left a comment
There was a problem hiding this comment.
test is green and code looks good, just need small refactoring.
Julian-Chu
approved these changes
Feb 3, 2021
Collaborator
Julian-Chu
left a comment
Julian-Chu
left a comment
There was a problem hiding this comment.
LGTM. Thanks for contribution!
Collaborator
|
I've released a new version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If the uploader has disabled embedding the video on other sites, parse video page. In this case we need to get the JSON for
ytInitialPlayerResponse(using regex) and unmarshal that into aplayerResponseDatastruct.Issues to fix
Please link issues this PR will fix:
#138