Temporary(?) fix for #196#197
Closed
raitonoberu wants to merge 3 commits intokkdai:masterfrom
raitonoberu:master
Closed
Temporary(?) fix for #196#197raitonoberu wants to merge 3 commits intokkdai:masterfrom raitonoberu:master
raitonoberu wants to merge 3 commits intokkdai:masterfrom
raitonoberu:master
Conversation
For some reason, a different duration returned, that's why I changed client_test.go
|
@raitonoberu it works for me. Thanks for the change. For those who need this change immediately:
|
Collaborator
|
Unfortunately two tests fail. |
Author
|
Yes, the tests fail because some data is missing. But this does not affect the operation of the package.
Another way is to stop using Thanks. |
|
I'm able to download videos, but they don't have audio. Can anyone reproduce? |
Collaborator
|
closed in favour of #198 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some additional parameters to the URL, so that the request returns 200. I've copied them from pytube.
The new response is slightly different.
Video.Durationis now taken fromprData.VideoDetails.LengthSeconds. I do not know why, but it is 1 second less than before, so I also changed the test.Video.PublishDateis missing. Pytube fetches it from the video page, so I also added a regex to fetch inparseVideoPage.get_video_infodoesn't return this information anymore.Here is the output of
go test: https://pastebin.com/9wQvwbJyYou have to decide what to do with the missing values.
Thanks.