Add some missing fields in Playlist object#231
Merged
corny merged 3 commits intokkdai:masterfrom Feb 4, 2022
ItsClairton:patch
Merged
Add some missing fields in Playlist object#231corny merged 3 commits intokkdai:masterfrom ItsClairton:patch
corny merged 3 commits intokkdai:masterfrom
ItsClairton:patch
Conversation
ItsClairton
changed the title
corny
requested changes
Jan 14, 2022
Collaborator
corny
left a comment
corny
left a comment
There was a problem hiding this comment.
Please add some tests. You could add asserts to TestGetVideoWithoutManifestURL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please tell us the changes you've made
Issues to fix
Please link issues this PR will fix:
#[issue number]
if no relevant issue, but this will fix something important for reference
, please free to open an issue.
Reminding
Something you can do before PR to reduce time to merge