Merged
Conversation
- function name - function body - function definition body
- function name in definition body - called function name
kkdai
approved these changes
Apr 20, 2020
Owner
kkdai
left a comment
kkdai
left a comment
There was a problem hiding this comment.
Oh my god, it helps a lot.
Thank you
Owner
This was referenced Apr 20, 2020
|
Thank you! This should fix https://github.com/prologic/tube/issues/12 once I have some time to test out this library as an alterantive! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Test Cases
All of the following cases works on my machine with this fix, but need more tests on other machines.
#25
go run main.go -o "test1".mov https://www.youtube.com/watch?v=54e6lBE3BoQ
#17
go run main.go -o "test2".mp4 https://www.youtube.com/watch?v=FHpvI8oGsuQ
#21
go run main.go -o "test3".mp4 https://www.youtube.com/watch?v=n3kPvBCYT3E
please provide valid file name for testing to avoid some cases that video title contains invalid characters for OS file system.
env: go1.14.1 windows/amd64