Skip to content

Add error check to decipher#81

Merged
kkc merged 5 commits intokkdai:masterfrom
Julian-Chu:add-error-check-to-decipher
Jul 21, 2020
Merged

Add error check to decipher#81
kkc merged 5 commits intokkdai:masterfrom
Julian-Chu:add-error-check-to-decipher

Conversation

@Julian-Chu
Copy link
Copy Markdown
Collaborator

Description

  • add error check for decipher
  • move decipher to own package
  • update makefile

Issues to fix

Please link issues this PR will fix:
#75

if no relevant issue, but this will fix something important for reference
, please free to open an issue.

Reminding

Something you can do before PR to reduce time to merge

  • run "make build" to build the code
  • run "make format" to reformat the code
  • run "make lint" if you are using unix system
  • run "make test-integration" to pass all tests

@kkc
Copy link
Copy Markdown
Collaborator

kkc commented Jul 21, 2020

LGTM, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants