-
Notifications
You must be signed in to change notification settings - Fork 928
Add support for multi-output filters; implement split filter
#20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Conflicts: ffmpeg/_run.py ffmpeg/nodes.py
|
Great! I'll test it on Saturday and let you know. |
|
This doesn't seem to work with import ffmpeg
i = ffmpeg.input("test.ogg")
s = i.split()
l = [s[i].output("out"+str(i)) for i in range(5)]
print(l)o = ffmpeg.merge_outputs(*l) |
|
Ooooooh looks like there aren't any tests for I'll make a fix. |
|
Ok should be fixed. Also note that I made it so that The And you can do the same thing with Basically anything that takes a |
|
This probably won't affect you, but I also uncovered this edgecase-ish bug: #23 |
|
Let me know if this fixes it for you. Thanks for testing |
|
Nope. See I added it manually to the command line and now works. Let me see what I can do with the code. |
Conflicts: ffmpeg/_filters.py ffmpeg/_utils.py ffmpeg/nodes.py ffmpeg/tests/test_ffmpeg.py
|
Should be fixed now. I'm gonna merge this. Let me know if there are any issues. |

The
splitoperator now does the right thing:This paves the way to having both multi-input and multi-output components. To access particular outputs of a multi-output node, use either the
.streamfunction or bracket shorthand:I decided to forego the automatic
splitstuff for now. It was probably more work to add multi-output support right away, but I think it's more correct in the long run. The automatic splitting will eventually happen as a pre-processing step and produce the same kind of graph as though thesplitwere inserted manually.