Skip to content

Add asplit filter #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 28, 2018
Merged

Add asplit filter #46

merged 4 commits into from
Jan 28, 2018

Conversation

@depau
Copy link
Collaborator

@depau depau commented Dec 22, 2017

Add asplit filter

@kkroening
Copy link
Owner

kkroening commented Dec 23, 2017

Needs test(s). Looks good otherwise. Will approve once the test is there.

@kkroening
Copy link
Owner

kkroening commented Dec 23, 2017

Also let's merge #47 into this so that CI can pass.

@depau
Copy link
Collaborator Author

depau commented Dec 23, 2017

Oh yeah I forgot tests. I'll add them.

@depau
Copy link
Collaborator Author

depau commented Jan 10, 2018

Okay, I added tests.

kkroening
kkroening approved these changes Jan 28, 2018
View reviewed changes
Copy link
Owner

@kkroening kkroening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kkroening kkroening merged commit a029d7a into kkroening:master Jan 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kkroening kkroening kkroening approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@depau @kkroening