Add @dprotaso as a serving approver#4426
Merged
knative-prow-robot merged 1 commit intoknative:masterfrom Jun 19, 2019
Merged
Conversation
knative-prow-robot
added
the
size/XS
|
/lgtm |
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
mattmoor
added a commit
to mattmoor/community
that referenced
this pull request
Feb 18, 2020
[Requirements](https://knative.dev/contributing/roles/#working-group-technical-lead): - [X] **Recognized as having expertise in the group’s subject matter.** - Led the implementation of Conversion Webhook support for knative/serving. - Participated in the v1beta1/v1 API task force. - Many other features and improvements - [X] **Approver for a relevant part of the codebase for at least 3 months.** - Approver for serving API since [June 2019](knative/serving#4426) - [X] **Member for at least 6 months.** - One of the earliest Knative (FKA Elafros) contributors! - [X] **Primary reviewer for 20 substantial PRs.** - [47 L, XL, XXL in knative/serving](https://github.com/knative/serving/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Amerged+-author%3Adprotaso+reviewed-by%3Adprotaso+-label%3Asize%2FS+-label%3Asize%2FXS+-label%3Asize%2FM+) - [4 L, XL, XXL in knative/pkg](https://github.com/knative/pkg/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Amerged+-author%3Adprotaso+reviewed-by%3Adprotaso+-label%3Asize%2FS+-label%3Asize%2FXS+-label%3Asize%2FM+) - [X] **Reviewed or merged at least 50 PRs.** - [67 reviewed](https://github.com/knative/serving/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Amerged+-author%3Adprotaso+reviewed-by%3Adprotaso+) + [58 merged](https://github.com/knative/serving/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Amerged+author%3Adprotaso) in serving - [10 reviewed](https://github.com/knative/pkg/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Amerged+-author%3Adprotaso+reviewed-by%3Adprotaso+) + [23 merged](https://github.com/knative/pkg/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Amerged+author%3Adprotaso) in pkg - [X] Sponsored by the technical oversight committee. /cc vaikas evankanderson > NOTE: This also removes @dgerd who announced last week that he plans to step down :(
6 tasks
knative-prow-robot
pushed a commit
to knative/community
that referenced
this pull request
Feb 24, 2020
[Requirements](https://knative.dev/contributing/roles/#working-group-technical-lead): - [X] **Recognized as having expertise in the group’s subject matter.** - Led the implementation of Conversion Webhook support for knative/serving. - Participated in the v1beta1/v1 API task force. - Many other features and improvements - [X] **Approver for a relevant part of the codebase for at least 3 months.** - Approver for serving API since [June 2019](knative/serving#4426) - [X] **Member for at least 6 months.** - One of the earliest Knative (FKA Elafros) contributors! - [X] **Primary reviewer for 20 substantial PRs.** - [47 L, XL, XXL in knative/serving](https://github.com/knative/serving/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Amerged+-author%3Adprotaso+reviewed-by%3Adprotaso+-label%3Asize%2FS+-label%3Asize%2FXS+-label%3Asize%2FM+) - [4 L, XL, XXL in knative/pkg](https://github.com/knative/pkg/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Amerged+-author%3Adprotaso+reviewed-by%3Adprotaso+-label%3Asize%2FS+-label%3Asize%2FXS+-label%3Asize%2FM+) - [X] **Reviewed or merged at least 50 PRs.** - [67 reviewed](https://github.com/knative/serving/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Amerged+-author%3Adprotaso+reviewed-by%3Adprotaso+) + [58 merged](https://github.com/knative/serving/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Amerged+author%3Adprotaso) in serving - [10 reviewed](https://github.com/knative/pkg/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Amerged+-author%3Adprotaso+reviewed-by%3Adprotaso+) + [23 merged](https://github.com/knative/pkg/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Amerged+author%3Adprotaso) in pkg - [X] Sponsored by the technical oversight committee. /cc vaikas evankanderson > NOTE: This also removes @dgerd who announced last week that he plans to step down :(
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From ROLES.md
First review - May 22, 2018 - 392 days ago
26L + 7XL + 7 XXL = 40 Reviews
https://github.com/knative/serving/pulls?utf8=%E2%9C%93&q=is%3Apr+-author%3Adprotaso+reviewed-by%3Adprotaso+-label%3Asize%2FS+-label%3Asize%2FXS+-label%3Asize%2FM
#892
#1208
#1223
#1225
#1321
#1351
#1364
#2402
#2447
#4152
75 Reviewed
https://github.com/knative/serving/pulls?utf8=%E2%9C%93&q=is%3Apr+reviewed-by%3Adprotaso+is%3Aclosed+
44 Merged PRs
https://github.com/knative/serving/pulls?utf8=%E2%9C%93&q=is%3Apr+author%3Adprotaso+is%3Amerged+
@mattmoor's approval was lost in the slack history - I swear it happened