Skip to content

Conversation

@ilovelinux
Copy link
Collaborator

@ilovelinux ilovelinux commented Aug 2, 2025

Fixes #2460

This PR fixes the issue for OpenAPI and JsonSchema

@ilovelinux ilovelinux changed the title Fixes #2460. Avoid mixing up configurations of different objects with the same name Avoid mixing up configurations of different objects with the same name Aug 2, 2025


class Friends(BaseModel):
pass

Check warning

Code scanning / CodeQL

Unnecessary pass Warning test

Unnecessary 'pass' statement.
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 2, 2025

CodSpeed Performance Report

Merging #2461 will not alter performance

Comparing ilovelinux:fix/ilovelinux-2460-same-name-objects (96bfcc2) with main (e30a46f)

Summary

✅ 32 untouched benchmarks



class Pets(BaseModel):
pass

Check warning

Code scanning / CodeQL

Unnecessary pass Warning test

Unnecessary 'pass' statement.
@ilovelinux ilovelinux marked this pull request as ready for review August 2, 2025 13:45
@codecov
Copy link

codecov bot commented Aug 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.04%. Comparing base (e30a46f) to head (96bfcc2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2461   +/-   ##
=======================================
  Coverage   98.04%   98.04%           
=======================================
  Files          66       66           
  Lines        8027     8042   +15     
  Branches      843      844    +1     
=======================================
+ Hits         7870     7885   +15     
  Misses        113      113           
  Partials       44       44           
Flag Coverage Δ
unittests 98.04% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix the merge conflicts.

@ilovelinux ilovelinux force-pushed the fix/ilovelinux-2460-same-name-objects branch from b15559a to a8810d1 Compare August 3, 2025 09:09
@ilovelinux ilovelinux requested a review from gaborbernat August 3, 2025 09:11
@gaborbernat gaborbernat merged commit 10da583 into koxudaxi:main Aug 3, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Model configuration got mixed up when objects with the same name in different schemas are defined

2 participants