DOM instantiation fails

[Martii]

Thanks for having this project available. :)

On to business...In the ./node_modules/diff/dist/diff.js there is some code of:

(function (global, factory) {
  typeof exports === 'object' && typeof module !== 'undefined' ? factory(exports) :
  typeof define === 'function' && define.amd ? define(['exports'], factory) :
  (global = global || self, factory(global.Diff = {}));
}(this, function (exports) { 'use strict';

This redefines the Object reference to be Diff instead of JsDiff with the snippet of global.Diff = {} for DOM usage as detailed in the current README.md under "Basic example in a web page".

Was this intended as one of the breaking changes with your semver major switch? e.g. are you wanting to change the DOCS to match the npmjs.com package name instead of the GitHub repo name?

Solutions I can think of are:

1. Fix the build system (which is currently beyond my expertise at the moment since I've never done this particular one)
2. Fix the README.md to this new norm. (I can PR this if needed/wanted but will also do the node identifiers for symmetry)
3. Something else?

... e.g. What was intended?

Thanks for the look.

Affected versions:

• diff@4.0.0
• diff@4.0.1

[silverwind]

Also noticed that window.JsDiff does no longer exist starting with 4.0.0, had to change it to window.Diff.

[Martii]

Well CI passed on Option 1 PR as well. And it seems to have corrected the naming with no other identifiers named in that file differently... so the choice is up to @kpdecker now.... or option 3 which I don't think I'll be able to guess 😸

Refs:

$ # Test on PR #246
$ git checkout fixNaming1
$ grunt
$ find ./{dist,lib} -type f -exec grep -l "JsDiff" {} \;
./dist/diff.js

$ find ./{.,dist,lib} -type f -exec grep -l "JsDiff" {} \;
././index.html
././README.md
././release-notes.md
././node_modules/diff/README.md
././node_modules/diff/diff.js
././node_modules/mocha/node_modules/diff/README.md
././node_modules/mocha/node_modules/diff/release-notes.md
././node_modules/mocha/node_modules/diff/lib/index.js
././node_modules/mocha/node_modules/diff/CONTRIBUTING.md
././node_modules/mocha/node_modules/diff/dist/diff.js
././node_modules/mocha/node_modules/diff/dist/diff.min.js
././node_modules/mocha/mocha.js
././CONTRIBUTING.md
././rollup.config.js
././dist/diff.js
././examples/web_example.html
././src/index.js
./dist/diff.js

$ # Test on current master 305a2b3
$ git checkout master
$ grunt
$ find ./{.,dist,lib} -type f -exec grep -l "JsDiff" {} \;
././index.html
././README.md
././release-notes.md
././node_modules/diff/README.md
././node_modules/diff/diff.js
././node_modules/mocha/node_modules/diff/README.md
././node_modules/mocha/node_modules/diff/release-notes.md
././node_modules/mocha/node_modules/diff/lib/index.js
././node_modules/mocha/node_modules/diff/CONTRIBUTING.md
././node_modules/mocha/node_modules/diff/dist/diff.js
././node_modules/mocha/node_modules/diff/dist/diff.min.js
././node_modules/mocha/mocha.js
././CONTRIBUTING.md
././examples/web_example.html
././src/index.js

$ diff -r jsdiff@master jsdiff@fixNaming1
... bunch of ./coverage changes snipped as inapplicable ...

diff -r jsdiff@master/dist/diff.js jsdiff@fixNaming1/dist/diff.js
4c4
<   (global = global || self, factory(global.Diff = {}));
---
>   (global = global || self, factory(global.JsDiff = {}));
diff -r jsdiff@master/.git/HEAD jsdiff@fixNaming1/.git/HEAD
1c1
< ref: refs/heads/master
---
> ref: refs/heads/fixNaming1
Binary files jsdiff@master/.git/index and jsdiff@fixNaming1/.git/index differ

... additional ./.git snipped for privacy ...

diff -r jsdiff@master/rollup.config.js jsdiff@fixNaming1/rollup.config.js
10c10
<         name: 'Diff',
---
>         name: 'JsDiff',

... confirmed no other identifier changes in tree from build using this criteria. (should be double checked by maintainer)

[jlpoolen]

I just installed using npm and had to modify my copy of the "working example":
function changed() {
//var diff = JsDiff[window.diffType](a.textContent, b.textContent);
var diff = Diff[window.diffType](a.textContent, b.textContent);

[Martii]

Thank you. :)