Support Object.create(null)
in JSON diffing
#493
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #492
I was recently trying to use
diff
to compare output from a library that makes use ofObject.create(null)
. This seems valid (if not encouraged) in some situations, butdiff
was throwing as thetypeof
this is'object'
and it is!== null
butobj.hasOwnProperty
does not exist.Instead, use
Object.prototype.hasOwnProperty.call(obj, key)
similar to the way thatObject.prototyope.toString
is used elsewhere in this library.