Skip to content

Support callback in patch functions, not just diffFoo functions #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ExplodingCabbage merged 9 commits into from
Jun 7, 2024
Merged

Support callback in patch functions, not just diffFoo functions #521

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
791ced2
Support callback option in structuredPatch
ExplodingCabbage Jun 7, 2024
4f0f6df
Test callback in structuredPatch
ExplodingCabbage Jun 7, 2024
f40a899
Add test of callback option to createPatch
ExplodingCabbage Jun 7, 2024
7136afe
Add callback support to createPatch
ExplodingCabbage Jun 7, 2024
4e10e80
Add one more test to get over the coverage threshold
ExplodingCabbage Jun 7, 2024
9de7f97
Update README
ExplodingCabbage Jun 7, 2024
146a61f
Support passing function as 'options' argument as with existing methods
ExplodingCabbage Jun 7, 2024
707ed3f
Add release notes
ExplodingCabbage Jun 7, 2024
60d4368
Add more tests to meet coverage threshold
ExplodingCabbage Jun 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Support passing function as 'options' argument as with existing methods
  • Loading branch information
@ExplodingCabbage
ExplodingCabbage committed Jun 7, 2024
commit 146a61f28b8ca6ddbc44bb35ebe39512f3755742
7 changes: 7 additions & 0 deletions src/patch/create.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ export function structuredPatch(oldFileName, newFileName, oldStr, newStr, oldHea
if (!options) {
options = {};
}
if (typeof options === 'function') {
options = {callback: options};
}
if (typeof options.context === 'undefined') {
options.context = 4;
}
Expand Down Expand Up @@ -158,6 +161,10 @@ export function formatPatch(diff) {
}

export function createTwoFilesPatch(oldFileName, newFileName, oldStr, newStr, oldHeader, newHeader, options) {
if (typeof options === 'function') {
options = {callback: options};
}

if (!options?.callback) {
const patchObj = structuredPatch(oldFileName, newFileName, oldStr, newStr, oldHeader, newHeader, options);
if (!patchObj) {
Expand Down