Skip to content

Fix stringifyReplacer #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 7, 2025
+75 −3
Merged

Fix stringifyReplacer #601

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7a19f50
Add tests of broken behaviour
ExplodingCabbage Apr 7, 2025
112e61b
Fix one test
ExplodingCabbage Apr 7, 2025
644781e
Correct my test and also make it more convincing
ExplodingCabbage Apr 7, 2025
1544bd2
Fix canonicalize; get new test passing
ExplodingCabbage Apr 7, 2025
264e5c3
Add release notes
ExplodingCabbage Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix canonicalize; get new test passing
  • Loading branch information
@ExplodingCabbage
ExplodingCabbage committed Apr 7, 2025
commit 1544bd2887c429ce9f2c9899a529413ef2a3e65b
4 changes: 2 additions & 2 deletions src/diff/json.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export function canonicalize(obj, stack, replacementStack, replacer, key) {
replacementStack = replacementStack || [];

if (replacer) {
obj = replacer(key, obj);
obj = replacer(key === undefined ? '' : key, obj);
}

let i;
Expand All @@ -43,7 +43,7 @@ export function canonicalize(obj, stack, replacementStack, replacer, key) {
canonicalizedObj = new Array(obj.length);
replacementStack.push(canonicalizedObj);
for (i = 0; i < obj.length; i += 1) {
canonicalizedObj[i] = canonicalize(obj[i], stack, replacementStack, replacer, key);
canonicalizedObj[i] = canonicalize(obj[i], stack, replacementStack, replacer, String(i));
}
stack.pop();
replacementStack.pop();
Expand Down