translation: Update the figures for the chapter of data sturcture #1083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuelinxin
reviewed
Feb 19, 2024
Contributor
yuelinxin
left a comment
yuelinxin
left a comment
There was a problem hiding this comment.
Great work on translating the figures! Please comment on the question below.
Contributor
There was a problem hiding this comment.
not the same font for the monospace characters, is this intentional?
Owner
Author
There was a problem hiding this comment.
Yes. I use Roboto Mono as the font for the code and formulas.
QiLOL
reviewed
Feb 25, 2024
docs-en/chapter_data_structure/character_encoding.assets/ascii_table.png
Show resolved
Hide resolved
docs-en/chapter_data_structure/character_encoding.assets/unicode_hello_algo.png
Show resolved
Hide resolved
...data_structure/classification_of_data_structure.assets/classification_phisical_structure.png
Show resolved
Hide resolved
Owner
Author
|
@QiLOL @yuelinxin All the comments addressed. Please take a look at the latest figures. |
Owner
Author
|
Thanks for the review @QiLOL @yuelinxin ! I'll merge this PR. Please let me know if there is anything to correct @yuelinxin . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this pull request (PR) pertains to Chinese-to-English translation, please confirm that you have read the contribution guidelines and complete the checklist below: