Skip to content

Remove params parameter from exec function #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theogravity merged 2 commits into from
Jul 11, 2023
Merged

Remove params parameter from exec function #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3cdb89
Remove `params` parameter from `exec` function
ar1k Jul 11, 2023
804ef54
Bump major version
Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "sqlite",
"version": "4.2.1",
"version": "5.0.0",
"description": "SQLite client for Node.js applications with SQL-based migrations API written in Typescript",
"main": "build/index.js",
"types": "build/index.d.ts",
Expand Down
5 changes: 2 additions & 3 deletions src/Database.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,12 +299,11 @@ export class Database<
* Comments are not allowed and will lead to runtime errors.
*
* @param {string} sql The SQL query to run.
* @param {any} [params, ...] Same as the `params` parameter of `all`
* @see https://github.com/mapbox/node-sqlite3/wiki/API#databaseexecsql-callback
*/
exec (sql: ISqlite.SqlType, ...params: any[]): Promise<void> {
exec (sql: ISqlite.SqlType): Promise<void> {
return new Promise((resolve, reject) => {
const sqlObj = toSqlParams(sql, params)
const sqlObj = toSqlParams(sql)

this.db.exec(sqlObj.sql, err => {
if (err) {
Expand Down