chore(backend): correct node id for metrics reporting#12213
Merged
google-oss-prow[bot] merged 1 commit intokubeflow:masterfrom Sep 3, 2025
Merged
chore(backend): correct node id for metrics reporting#12213google-oss-prow[bot] merged 1 commit intokubeflow:masterfrom
google-oss-prow[bot] merged 1 commit intokubeflow:masterfrom
Conversation
2433a56 to
f6f9516
Compare
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
f6f9516 to
c6ac0fb
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
krishanbhasin-px
pushed a commit
to krishanbhasin-px/kubeflow-pipelines
that referenced
this pull request
Sep 18, 2025
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes:
This fixes metrics reporting for v1 pipeline runs that log metrics. Previously the wrong node id was sent to the api server.
You can verify this with this sample pipeline:
sample.py
Here's the resulting json if you query this run:
sample.json
{ "run": { "id": "aee677a3-c3a1-47a2-bbbb-81821f47c447", "name": "Run of simple_pipeline (261da)", "pipeline_spec": {}, # omitted "resource_references": [ { "key": { "type": "EXPERIMENT", "id": "fa3653ac-312d-46bc-a67a-a9eaab61c779" }, "relationship": "OWNER" }, { "key": { "type": "PIPELINE_VERSION", "id": "428f5c85-d0c6-4062-b795-76b846272c59" }, "relationship": "CREATOR" } ], "service_account": "pipeline-runner", "created_at": "2025-09-03T19:50:04Z", "scheduled_at": "2025-09-03T19:50:04Z", "finished_at": "2025-09-03T19:50:14Z", "status": "Succeeded", "metrics": [ { "name": "accuracy", "node_id": "simple-metric-logging-pipeline-gxltq-train-op-3397519976", "number_value": 0.7160825905928586, "format": "PERCENTAGE" } ] }, "pipeline_runtime": { } # omitted }Checklist: