Skip to content

fix(frontend): restrict pods API based on namespace access#12528

Merged
google-oss-prow[bot] merged 2 commits intokubeflow:masterfrom
demarna1:restrict-pipelines
Jan 18, 2026
Merged

fix(frontend): restrict pods API based on namespace access#12528
google-oss-prow[bot] merged 2 commits intokubeflow:masterfrom
demarna1:restrict-pipelines

Conversation

@demarna1
Copy link
Contributor

@demarna1 demarna1 commented Dec 5, 2025

Description of your changes:

Closes #12509

View the linked issue for additional context and reproduction of the issue.

Test Evidence

Reproduced the steps in #12509 and confirmed the issue no longer exists.

Checklist:

@google-oss-prow
Copy link

Hi @demarna1. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JerT33
Copy link
Contributor

JerT33 commented Dec 9, 2025

/ok-to-test

@demarna1 demarna1 force-pushed the restrict-pipelines branch 2 times, most recently from 2319699 to 10839ee Compare December 17, 2025 14:27
Copy link
Contributor

@zazulam zazulam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@droctothorpe
Copy link
Collaborator

This is fantastic, @demarna1. Thank you for the contribution.

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: droctothorpe, zazulam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@droctothorpe
Copy link
Collaborator

Rebased. I'd like to get this merged.

@droctothorpe
Copy link
Collaborator

/retest

@droctothorpe
Copy link
Collaborator

Looks like the frontend tests may need some refactoring @demarna1.

@demarna1 demarna1 force-pushed the restrict-pipelines branch 2 times, most recently from 8c993b6 to dea7f95 Compare January 15, 2026 15:56
Signed-off-by: Noah DeMarco <noah.demarco@gmail.com>
@demarna1 demarna1 force-pushed the restrict-pipelines branch 2 times, most recently from 33d4d2f to 19f7bfa Compare January 17, 2026 19:21
Signed-off-by: Noah DeMarco <noah.demarco@gmail.com>
@demarna1
Copy link
Contributor Author

Addressed issue with unit test. Should be good now. cc @droctothorpe @zazulam

@zazulam
Copy link
Contributor

zazulam commented Jan 18, 2026

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jan 18, 2026
@google-oss-prow google-oss-prow bot merged commit dbc2319 into kubeflow:master Jan 18, 2026
25 checks passed
@demarna1 demarna1 deleted the restrict-pipelines branch January 18, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[frontend] Pod spec, events, and logs are not namespace restricted

4 participants