fix(frontend): restrict pods API based on namespace access#12528
fix(frontend): restrict pods API based on namespace access#12528google-oss-prow[bot] merged 2 commits intokubeflow:masterfrom
Conversation
|
Hi @demarna1. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
2319699 to
10839ee
Compare
|
This is fantastic, @demarna1. Thank you for the contribution. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: droctothorpe, zazulam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
10839ee to
3736e0f
Compare
3736e0f to
8872815
Compare
|
Rebased. I'd like to get this merged. |
|
/retest |
|
Looks like the frontend tests may need some refactoring @demarna1. |
8c993b6 to
dea7f95
Compare
Signed-off-by: Noah DeMarco <noah.demarco@gmail.com>
33d4d2f to
19f7bfa
Compare
Signed-off-by: Noah DeMarco <noah.demarco@gmail.com>
19f7bfa to
3b1eed9
Compare
|
Addressed issue with unit test. Should be good now. cc @droctothorpe @zazulam |
|
/lgtm |
Description of your changes:
Closes #12509
View the linked issue for additional context and reproduction of the issue.
Test Evidence
Reproduced the steps in #12509 and confirmed the issue no longer exists.
Checklist: