Skip to content

Cleanup kind workflows and Harden release downloads(incl. artifact paging)#12549

Merged
google-oss-prow[bot] merged 2 commits intokubeflow:masterfrom
sduvvuri1603:fix/kind-workflow-cleanup
Dec 12, 2025
Merged

Cleanup kind workflows and Harden release downloads(incl. artifact paging)#12549
google-oss-prow[bot] merged 2 commits intokubeflow:masterfrom
sduvvuri1603:fix/kind-workflow-cleanup

Conversation

@sduvvuri1603
Copy link
Contributor

@sduvvuri1603 sduvvuri1603 commented Dec 11, 2025 •
edited
Loading

Description of your changes:

  • add a shared cleanup step to integration-tests-v1, kfp-webhooks, and e2e-test-frontend so we free disk and skip log collection when the kubeflow namespace never comes up; this unblocks the disk-exhaustion regressions seen in feat: Add pipeline run parallelism config #12442

  • harden .github/actions/check-artifact-exists so GitHub’s 403 pagination limit is treated as “artifact not found” rather than crashing the job

  • fix our Docker builds (backend/Dockerfile, test/release/Dockerfile.release) to fetch Argo CLI and git-cliff with Accept: application/octet-stream and then extract, avoiding HTML responses that were breaking the unpack step

@google-oss-prow
Copy link

google-oss-prow bot commented Dec 11, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@sduvvuri1603 sduvvuri1603 force-pushed the fix/kind-workflow-cleanup branch from c9e4ab9 to 6ce6ab0 Compare December 11, 2025 14:55
@sduvvuri1603 sduvvuri1603 marked this pull request as ready for review December 11, 2025 15:17
@google-oss-prow
Copy link

google-oss-prow bot commented Dec 11, 2025

@sduvvuri1603: No presubmit jobs available for kubeflow/pipelines@master

Details

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sduvvuri1603 sduvvuri1603 marked this pull request as draft December 11, 2025 15:18
@sduvvuri1603
Copy link
Contributor Author

sduvvuri1603 commented Dec 11, 2025

/retest

@google-oss-prow google-oss-prow bot added size/XS and removed size/M labels Dec 11, 2025
@sduvvuri1603 sduvvuri1603 force-pushed the fix/kind-workflow-cleanup branch 2 times, most recently from a1d11c7 to e64b119 Compare December 11, 2025 16:40
@google-oss-prow google-oss-prow bot added size/S and removed size/XS labels Dec 11, 2025
@sduvvuri1603 sduvvuri1603 force-pushed the fix/kind-workflow-cleanup branch from e64b119 to 32b002e Compare December 11, 2025 16:50
@google-oss-prow google-oss-prow bot added size/M and removed size/S labels Dec 11, 2025
@sduvvuri1603 sduvvuri1603 force-pushed the fix/kind-workflow-cleanup branch 2 times, most recently from 494471f to 6433f30 Compare December 11, 2025 17:06
@google-oss-prow google-oss-prow bot added size/S and removed size/M labels Dec 11, 2025
@sduvvuri1603 sduvvuri1603 force-pushed the fix/kind-workflow-cleanup branch from 6433f30 to de4fabd Compare December 11, 2025 17:12
@google-oss-prow google-oss-prow bot added size/M and removed size/S labels Dec 11, 2025
@sduvvuri1603 sduvvuri1603 force-pushed the fix/kind-workflow-cleanup branch from de4fabd to f505767 Compare December 11, 2025 17:21
@sduvvuri1603
chore: add cleanup jobs for kind workflows
3a8389e 
Signed-off-by: sduvvuri1603 <sduvvuri@redhat.com>
@sduvvuri1603
Copy link
Contributor Author

sduvvuri1603 commented Dec 11, 2025

/retest

@sduvvuri1603 sduvvuri1603 marked this pull request as ready for review December 11, 2025 19:09
nsingla
nsingla reviewed Dec 11, 2025
View reviewed changes
nsingla
nsingla reviewed Dec 11, 2025
View reviewed changes
nsingla
nsingla approved these changes Dec 11, 2025
View reviewed changes
Copy link
Contributor

@nsingla nsingla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, follow up is required to resolve some of the ask in this PR

@google-oss-prow google-oss-prow bot added the lgtm label Dec 11, 2025
hbelmiro
hbelmiro reviewed Dec 11, 2025
View reviewed changes
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sduvvuri1603 I noticed some changes that seems unrelated to the cleanup.
I'm not against including them in this PR If they're really unrelated, but necessary. But then we need to update the PR's title and description to include those changes.

@sduvvuri1603 sduvvuri1603 changed the title Add cleanup jobs for Kind workflows cleanup kind workflows and harden release downloads Dec 11, 2025
@sduvvuri1603 sduvvuri1603 changed the title cleanup kind workflows and harden release downloads Cleanup kind workflows and Harden release downloads Dec 11, 2025
@sduvvuri1603
chore: cleanup kind workflows and harden artifacts
2870e3b 
Signed-off-by: sduvvuri1603 <sduvvuri@redhat.com>
@sduvvuri1603
Copy link
Contributor Author

sduvvuri1603 commented Dec 12, 2025

/retest

@sduvvuri1603 sduvvuri1603 changed the title Cleanup kind workflows and Harden release downloads Cleanup kind workflows and Harden release downloads(incl. artifact paging) Dec 12, 2025
hbelmiro
hbelmiro approved these changes Dec 12, 2025
View reviewed changes
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm as long as @nsingla's comments are addressed in a follow-up PR.
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Dec 12, 2025
@HumairAK
Copy link
Collaborator

HumairAK commented Dec 12, 2025 •
edited
Loading

/approve

@google-oss-prow
Copy link

google-oss-prow bot commented Dec 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbelmiro, HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit df0f869 into kubeflow:master Dec 12, 2025
195 of 199 checks passed
pschoen-itsc pushed a commit to pschoen-itsc/kf-pipelines that referenced this pull request Dec 12, 2025
@sduvvuri1603 @pschoen-itsc
Cleanup kind workflows and Harden release downloads(incl. artifact pa…
a7c7099 
…ging) (kubeflow#12549)

* chore: add cleanup jobs for kind workflows

Signed-off-by: sduvvuri1603 <sduvvuri@redhat.com>

* chore: cleanup kind workflows and harden artifacts

Signed-off-by: sduvvuri1603 <sduvvuri@redhat.com>

---------

Signed-off-by: sduvvuri1603 <sduvvuri@redhat.com>
Signed-off-by: Patrick Schönthaler <patrick.schoenthaler@itsc.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@droctothorpe droctothorpe Awaiting requested review from droctothorpe

@rimolive rimolive Awaiting requested review from rimolive

@gmfrasca gmfrasca Awaiting requested review from gmfrasca

@mprahl mprahl Awaiting requested review from mprahl

@zazulam zazulam Awaiting requested review from zazulam

2 more reviewers

@hbelmiro hbelmiro hbelmiro approved these changes

@nsingla nsingla nsingla approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@HumairAK HumairAK

@hbelmiro hbelmiro

@nsingla nsingla

Labels

approved lgtm size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sduvvuri1603 @HumairAK @hbelmiro @nsingla