Grant create events permissions to Controller #2616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rockawear
changed the title
…ubeflow#2605) * Grant get/patch permissions for SparkConnect CRD to hook ClusterRole Signed-off-by: Yi Chen <[email protected]> * Update Helm unit tests Signed-off-by: Yi Chen <[email protected]> --------- Signed-off-by: Yi Chen <[email protected]> <!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, check our contributor guidelines: https://www.kubeflow.org/docs/about/contributing 2. To know more about how to develop with the Spark operator, check the developer guide: https://www.kubeflow.org/docs/components/spark-operator/developer-guide/ 3. If you want *faster* PR reviews, check how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews 4. Please open an issue to discuss significant work before you start. We appreciate your contributions and don't want your efforts to go to waste! --> ## Purpose of this PR <!-- Provide a clear and concise description of the changes. Explain the motivation behind these changes and link to relevant issues or discussions. --> **Proposed changes:** - <Change 1> - <Change 2> - <Change 3> ## Change Category <!-- Indicate the type of change by marking the applicable boxes. --> - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] Feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that could affect existing functionality) - [ ] Documentation update ### Rationale <!-- Provide reasoning for the changes if not already covered in the description above. --> ## Checklist <!-- Before submitting your PR, please review the following: --> - [ ] I have conducted a self-review of my own code. - [ ] I have updated documentation accordingly. - [ ] I have added tests that prove my changes are effective or that my feature works. - [ ] Existing unit tests pass locally with my changes. ### Additional Notes <!-- Include any additional notes or context that could be helpful for the reviewers here. --> Signed-off-by: Rockawear <[email protected]>
Rockawear
force-pushed
the
grant-controller-events
branch
from
8fe4883 to
0b99c03
Compare
1 task
ChenYi015
reviewed
Jul 23, 2025
Member
|
@Rockawear Thanks for reporting and fixing the RBAC issue. |
Signed-off-by: Rockfeller Fixe <[email protected]>
ChenYi015
approved these changes
Jul 23, 2025
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ChenYi015 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ChenYi015
changed the title
1 task
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Proposed changes:
Change Category
Rationale
Checklist
Additional Notes