fix: webhook encoder configuration #2664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perform same changes that were done for the controller but then for the webhook. This seem to have been forgotten in PR kubeflow#2580 Signed-off-by: pvbouwel <[email protected]>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ChenYi015 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 task
1 task
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perform same changes that were done for the controller but then for the webhook.
This seem to have been forgotten in PR #2580
Purpose of this PR
Make sure the helm value
webhook.logEncoderintroduced in #2580 is actually used.Proposed changes:
Change Category
Rationale
To allow JSON logging for all the components.
Checklist
Additional Notes
I have done these changes and created a custom build which works.
This is copying what @ChenYi015 did on #2580 so likely easy to review for him.