Skip to content

Conversation

@shadowinlife
Copy link
Contributor

Purpose of this PR

Proposed changes:

  • Refactor the unit tests for web_ui.go. Remove commented-out code and add new unit test logic to restore coverage to 90%.

Change Category

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Rationale

Checklist

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

Additional Notes

@ChenYi015
Copy link
Member

@shadowinlife Thanks for fixing the unit tests.
/approve

@google-oss-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChenYi015

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit d0cd834 into kubeflow:master Nov 3, 2025
18 checks passed
aryankumar04 pushed a commit to aryankumar04/spark-operator that referenced this pull request Nov 6, 2025
Signed-off-by: 世行 <[email protected]>
Co-authored-by: 世行 <[email protected]>
Signed-off-by: Aryan Kumar <[email protected]>
@ChenYi015 ChenYi015 mentioned this pull request Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants