Migrate to public ECR#1256
Conversation
terrytangyuan
left a comment
terrytangyuan
left a comment
There was a problem hiding this comment.
Not familiar with jsonnet either so I'll defer this to others to review.
|
Looks like it failed for https://github.com/kubeflow/tf-operator/blob/047d6af30e5a6a26c5a5a51500a1cdface418ac3/sdk/python/test/test_e2e.py Client get timeout for requests, don't know why it happen. Retest to see if it's reproducible /test kubeflow-tf-operator-presubmit |
|
I'll create another PR to test if original test pass or not |
|
Failed for wrong tf-operator tag, fixed now, let's see if test passes |
|
Failed for |
|
Cleaned up code and test succeed now @gaocegege @Jeffwan @andreyvelich Can you help take a look? |
|
/unhold |
gaocegege
left a comment
gaocegege
left a comment
There was a problem hiding this comment.
/lgtm
Thanks for your contribution! 🎉 👍
|
/lgtm |
|
Can any of you help approve? I'll hold here first, since we're kind of urgent in release /hold |
|
@PatrickXYS Can you document debug information somewhere? |
| fieldRef: | ||
| fieldPath: metadata.name | ||
| image: gcr.io/kubeflow-images-public/tf-operator:v0.6.0 | ||
| image: public.ecr.aws/j1r0q0g6/training/tf-operator |
There was a problem hiding this comment.
CI already cover image build to public ECR?
There was a problem hiding this comment.
CI push to private ECR
CD push to public ECR
The registry is defined differently in the prow_config.yaml file
| - examples/* | ||
| params: | ||
| registry: "gcr.io/kubeflow-ci" | ||
| registry: "809251082950.dkr.ecr.us-west-2.amazonaws.com/tf-operator" |
| - postsubmit | ||
| params: | ||
| registry: "gcr.io/kubeflow-images-public" | ||
| registry: "public.ecr.aws/j1r0q0g6/training/tf-operator" |
|
@Jeffwan I'll issue a follow up PR to document debug information in test folder |
|
I don't intend to push, but let's get it fixed by this week, since 03/23 will be the target date to cut 1.3RC. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ChanYiLin, PatrickXYS The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is because we originally have another deployment file for testing not the one under manifest |
|
/unhold Unhold to merge |
7 participants
Resolves #1205
It's still WIP, not familiar with jsonnet syntax, and it's has been deprecated years...There's requirement to migrate from jsonnet-generated workflow to python-generated workflow, otherwise, it's difficult to maintain.
/hold
Hold until test succeed