Add CI to run the tests for Go

[tenzen-y]

Signed-off-by: tenzen-y yuki.iwai.tz@gmail.com

Add CI to run the tests for Go using GitHub Actions.

resolves: #1436

/assign
/cc @Jeffwan

[tenzen-y]

/assign @Jeffwan

[tenzen-y]

Is it possible to change the repository name in coveralls.io from tf-operator to training-operator?

[Jeffwan]

Is it possible to change the repository name in coveralls.io from tf-operator to training-operator?

@tenzen-y you mean migrate historical data? Seem training-operator has been synced there https://coveralls.io/github/kubeflow/training-operator. I doubt we can migrate previous data or not.

[Jeffwan]

em.. seems after the rename, prow testing is disabled for some reason.
/cc @andreyvelich @kubeflow/wg-training-leads

[andreyvelich]

em.. seems after the rename, prow testing is disabled for some reason. /cc @andreyvelich @kubeflow/wg-training-leads

Yes, we should merge this: kubeflow/testing#967.
Let's try to merge it and see if prow will use the new repo ?

[andreyvelich]

Thank you for this enhancement @tenzen-y!
I left few comments.

[tenzen-y]

Is it possible to change the repository name in coveralls.io from tf-operator to training-operator?

@tenzen-y you mean migrate historical data? Seem training-operator has been synced there https://coveralls.io/github/kubeflow/training-operator. I doubt we can migrate previous data or not.

Thank you for looking into coveralls. @Jeffwan

[Jeffwan]

/test

[aws-kf-ci-bot]

@Jeffwan: The /test command needs one or more targets.
The following commands are available to trigger jobs:

• /test kubeflow-training-operator-presubmit

Use /test all to run all jobs.

Details

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tenzen-y]

/test kubeflow-training-operator-presubmit

[Jeffwan]

@tenzen-y CI still needs some changes

Traceback (most recent call last):
  File "/usr/lib/python3.8/runpy.py", line 192, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib/python3.8/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/src/kubeflow/testing/py/kubeflow/testing/run_e2e_workflow.py", line 720, in <module>
    final_result = main()
  File "/src/kubeflow/testing/py/kubeflow/testing/run_e2e_workflow.py", line 710, in main
    return run(args, file_handler)
  File "/src/kubeflow/testing/py/kubeflow/testing/run_e2e_workflow.py", line 338, in run
    ks_cmd = ks_util.get_ksonnet_cmd(w.app_dir)
  File "/src/kubeflow/testing/py/kubeflow/testing/ks_util.py", line 46, in get_ksonnet_cmd
    with open(app_yaml_file) as app_yaml:
FileNotFoundError: [Errno 2] No such file or directory: '/src/kubeflow/tf-operator/test/workflows/app.yaml'

[tenzen-y]

@tenzen-y CI still needs some changes

Traceback (most recent call last):
  File "/usr/lib/python3.8/runpy.py", line 192, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib/python3.8/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/src/kubeflow/testing/py/kubeflow/testing/run_e2e_workflow.py", line 720, in <module>
    final_result = main()
  File "/src/kubeflow/testing/py/kubeflow/testing/run_e2e_workflow.py", line 710, in main
    return run(args, file_handler)
  File "/src/kubeflow/testing/py/kubeflow/testing/run_e2e_workflow.py", line 338, in run
    ks_cmd = ks_util.get_ksonnet_cmd(w.app_dir)
  File "/src/kubeflow/testing/py/kubeflow/testing/ks_util.py", line 46, in get_ksonnet_cmd
    with open(app_yaml_file) as app_yaml:
FileNotFoundError: [Errno 2] No such file or directory: '/src/kubeflow/tf-operator/test/workflows/app.yaml'

@Jeffwan I fixed this error in e65a9fe.

[Jeffwan]

We need to fix test path as well.

https://argo.kubeflow-testing.com/workflows/kubeflow-test-infra/kubeflow-training-operator-presubmit-v1-1440-e65a9fe-6704-8145?tab=workflow&nodeId=kubeflow-training-operator-presubmit-v1-1440-e65a9fe-6704-8145-1907657365

[Jeffwan]

Can you help update tf reference here? (skip testServerImage)

[tenzen-y]

Can you help update tf reference here? (skip testServerImage)

Sure.

[tenzen-y]

Maybe, I think fixed the tests.
WDYT?@Jeffwan

https://argo.kubeflow-testing.com/workflows/kubeflow-test-infra/kubeflow-training-operator-presubmit-v1-1440-43927c5-6784-46f6?tab=workflow

[Jeffwan]

Great! @tenzen-y You make it! changes look good to me. hold it for one day for other reviewers @andreyvelich @kubeflow/wg-training-leads

/lgtm
/approve
/hold

[terrytangyuan]

This is great. Thank you for your contribution!

[google-oss-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan, tenzen-y, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [Jeffwan,terrytangyuan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Jeffwan]

Got approval from Terry and we can merge this.

/unhold

[tenzen-y]

Thanks for the review! @Jeffwan @andreyvelich @terrytangyuan