fix: generate printer columns for job crds

[henrysecond1]

Hi, just noticed that additionalPrinterColumns was removed in crd, so I added it using kubebuilder marker.

Please take a look, thanks.

Previous

• https://github.com/kubeflow/training-operator/blob/v1.2.1/manifests/base/crd.yaml#L6
• https://github.com/kubeflow/pytorch-operator/blob/master/manifests/base/crd.yaml#L6

Current (removed)

• https://github.com/kubeflow/training-operator/blob/master/manifests/base/crds/kubeflow.org_tfjobs.yaml#L10
• https://github.com/kubeflow/training-operator/blob/master/manifests/base/crds/kubeflow.org_pytorchjobs.yaml#L10

[aws-kf-ci-bot]

Hi @henrysecond1. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gaocegege]

/ok-to-test

[gaocegege]

I am wondering if Is it generated by kubebuilder?

[henrysecond1]

Yes, it is automatically generated by kubebuilder. Maybe it is just sorted by alphabetical order..?

[gaocegege]

SGTM!

[gaocegege]

Thanks for your contribution! 🎉 👍

[henrysecond1]

Thanks for your contribution! 🎉 👍

Thanks for checking the PR :)

[gaocegege]

/lgtm

[gaocegege]

/assign @johnugeorge @Jeffwan

[coveralls]

Pull Request Test Coverage Report for Build 1384869466

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 8.161%

---

Totals
Change from base Build 1343735744:	0.0%
Covered Lines:	311
Relevant Lines:	3811

---

💛 - Coveralls

[johnugeorge]

Can you add for other operators as well?

[gaocegege]

/retest

[henrysecond1]

Can you add for other operators as well?

Sure, I added it for all operators (mxjob, tfjob, pytorchjob, xgboostjob)

[Jeffwan]

This should be part of #1301. @henrysecond1 If you have design on the overall experience, feel free to write a short proposal in the issue for discussion or cut a PR directly.

/lgtm

[gaocegege]

/approve

[google-oss-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege, henrysecond1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [gaocegege]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[henrysecond1]

This should be part of #1301. @henrysecond1 If you have design on the overall experience, feel free to write a short proposal in the issue for discussion or cut a PR directly.

oh, I didn't check that issue, thank you.